-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: updated link for migrate_docker2containerd.md #11729
base: master
Are you sure you want to change the base?
Conversation
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kundan2707, VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest
|
/retest-failed
Weird that rocky failure look like a flake...
|
Hum let's try one more time...
/retest-failed
|
481ff06
to
79f14a4
Compare
New changes are detected. LGTM label has been removed. |
/retest |
/retitle Docs: updated link for migrate_docker2containerd.md |
* [Cgroups](/docs/operations/cgroups.md) | ||
* [Encrypting-secret-data-at-rest](/docs/operations/encrypting-secret-data-at-rest.md) | ||
* [Etcd](/docs/operations/etcd.md) | ||
* [Ha-mode](/docs/operations/ha-mode.md) | ||
* [Hardening](/docs/operations/hardening.md) | ||
* [Integration](/docs/operations/integration.md) | ||
* [Large-deployments](/docs/operations/large-deployments.md) | ||
* [Mirror](/docs/operations/mirror.md) | ||
* [Nodes](/docs/operations/nodes.md) | ||
* [Offline-environment](/docs/operations/offline-environment.md) | ||
* [Port-requirements](/docs/operations/port-requirements.md) | ||
* [Recover-control-plane](/docs/operations/recover-control-plane.md) | ||
* [Upgrades](/docs/operations/upgrades.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* [Cgroups](/docs/operations/cgroups.md) | |
* [Encrypting-secret-data-at-rest](/docs/operations/encrypting-secret-data-at-rest.md) | |
* [Etcd](/docs/operations/etcd.md) | |
* [Ha-mode](/docs/operations/ha-mode.md) | |
* [Hardening](/docs/operations/hardening.md) | |
* [Integration](/docs/operations/integration.md) | |
* [Large-deployments](/docs/operations/large-deployments.md) | |
* [Mirror](/docs/operations/mirror.md) | |
* [Nodes](/docs/operations/nodes.md) | |
* [Offline-environment](/docs/operations/offline-environment.md) | |
* [Port-requirements](/docs/operations/port-requirements.md) | |
* [Recover-control-plane](/docs/operations/recover-control-plane.md) | |
* [Upgrades](/docs/operations/upgrades.md) |
I don't recommend you modify it directly; pre-commit
will check, and if it's not consistent, it won't pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tico88612 I will revert changes.
This only really help with the easiest part of building your inventory (listing the hosts) as you still need to edit your groups vars and similar. The opaqueness of the script does not really help our users to understand their own inventory. Furthermore, there is not really a reason that something which is common to all the Ansible ecosystem should be done in a special way for Kubespray.
contrib/dind use inventory_builder, which is removed. It overlaps with the function of kind (Kubernetes in Docker) and has not see change (apart from linting driven ones) for a long time. It also does not seem to work (provisioning playbook crash).
There is no need to repeat the full example here, simply state what variables are.
- The bastion is not needed for a simple example - All is implicit we can just define our host in groups directly
Our README is currently pretty cluttered: - Part of the README duplicates docs/getting_started/getting-started.md -> Remove duplicates and extract useful info into the getting-started.md - General info on Ansible environment troubleshooting -> remove most of it as it's not specific to Kubespray, move to docs/ansible/ansible.md -> split inventory-related stuff of ansible.md into it's own file. This should host documentation on how to manages Kubespray inventories in the future. ansible.md: - remove the list of "Unused" variables, as: 1. It's not accurate 2. What matters is where users should put their variables
79f14a4
to
a0bc499
Compare
@kundan2707 Your PR shouldn't contain commit records from other PRs. You should only have one commit. (only a0bc499 record) |
What type of PR is this?
/kind bug
/kind documentation
What this PR does / why we need it: Link correction
Which issue(s) this PR fixes: 11727
Fixes #11727
Special notes for your reviewer:
Does this PR introduce a user-facing change?: